Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: [IOAPPX-405] Removing unused react imports #6562

Merged
merged 37 commits into from
Jan 17, 2025
Merged

chore: [IOAPPX-405] Removing unused react imports #6562

merged 37 commits into from
Jan 17, 2025

Conversation

LeleDallas
Copy link
Contributor

Short description

This pull request updates the ESLint and Babel configurations, along with package dependencies, to support the latest version of the JSX transform. This new transform enable the use of JSX without importing React.

List of changes proposed in this pull request

  • Apply changes as described in official documentation here

How to test

Ensure that the application works as expected, without any compilation errors or runtime crashes

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 17, 2024 •
edited
Loading

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOAPPX-405

@codecov Codecov
Copy link

codecov bot commented Dec 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 52.80899% with 84 lines in your changes missing coverage. Please review.

Project coverage is 49.86%. Comparing base (2d7127a) to head (a5b59cc).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...atures/barcode/hooks/useIOBarcodeCameraScanner.tsx 0.00% 9 Missing ⚠️
ts/components/ui/LightModal.tsx 22.22% 7 Missing ⚠️
...eens/merchants/CgnMerchantCategoriesListScreen.tsx 0.00% 6 Missing ⚠️
...n/screens/merchants/CgnMerchantsListByCategory.tsx 0.00% 5 Missing ⚠️
ts/features/design-system/core/DSNumberPad.tsx 0.00% 5 Missing ⚠️
...us/common/components/BonusInformationComponent.tsx 0.00% 4 Missing ⚠️
...components/cie/CieRequestAuthenticationOverlay.tsx 25.00% 3 Missing ⚠️
...ures/bonus/common/components/TosBonusComponent.tsx 25.00% 3 Missing ⚠️
ts/features/design-system/core/DSTextFields.tsx 0.00% 3 Missing ⚠️
ts/components/bottomSheet/BottomSheetHeader.tsx 33.33% 2 Missing ⚠️
... and 28 more
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6562   +/-   ##
=======================================
  Coverage   49.85%   49.86%           
=======================================
  Files        1564     1564           
  Lines       32370    32358   -12     
  Branches     7288     7337   +49     
=======================================
- Hits        16138    16135    -3     
+ Misses      16194    16173   -21     
- Partials       38       50   +12
Files with missing lines Coverage Δ
ts/components/AnimatedImage.tsx 83.33% <ø> (ø)
ts/components/AppVersion.tsx 100.00% <ø> (ø)
ts/components/BonusCard/BonusCard.tsx 93.93% <100.00%> (ø)
ts/components/BonusCard/BonusCardCounter.tsx 92.00% <100.00%> (ø)
.../components/BonusCard/BonusCardScreenComponent.tsx 100.00% <ø> (ø)
ts/components/BonusCard/BonusCardShape.tsx 81.81% <ø> (ø)
ts/components/BonusCard/BonusCardStatus.tsx 92.30% <ø> (ø)
ts/components/BulletList.tsx 71.42% <ø> (ø)
ts/components/CalendarList.tsx 20.00% <ø> (ø)
ts/components/Carousel.tsx 88.23% <ø> (ø)
... and 236 more

... and 240 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d7127a...a5b59cc. Read the comment docs.

@LeleDallas LeleDallas self-assigned this Dec 18, 2024
mastro993
mastro993 approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@mastro993 mastro993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

CrisTofani
CrisTofani approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@CrisTofani CrisTofani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LeleDallas LeleDallas added this pull request to the merge queue Jan 17, 2025
Merged via the queue into master with commit b84f0d1 Jan 17, 2025
21 checks passed
@LeleDallas LeleDallas deleted the IOAPPX-405-remove-react-import- branch January 17, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mastro993 mastro993 mastro993 approved these changes

@Vangaorth Vangaorth Vangaorth approved these changes

@CrisTofani CrisTofani CrisTofani approved these changes

@dmnplb dmnplb Awaiting requested review from dmnplb dmnplb is a code owner

@ChrisMattew ChrisMattew Awaiting requested review from ChrisMattew ChrisMattew is a code owner

@gispada gispada Awaiting requested review from gispada gispada is a code owner

@freddi301 freddi301 Awaiting requested review from freddi301 freddi301 is a code owner

@thisisjp thisisjp Awaiting requested review from thisisjp

Assignees

@LeleDallas LeleDallas

Labels
Cross
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LeleDallas @CrisTofani @Vangaorth @mastro993